Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMBARI-24832 - Infra Manager: set archive file permission on hdfs to 640 #11

Merged
merged 3 commits into from Oct 29, 2018
Merged

AMBARI-24832 - Infra Manager: set archive file permission on hdfs to 640 #11

merged 3 commits into from Oct 29, 2018

Conversation

kasakrisz
Copy link
Contributor

What changes were proposed in this pull request?

When archiving solr documents to hdfs set the permission of the files to 640

How was this patch tested?

UTs and ITs passed.

Manually:

  1. Deploy Ambari and a cluster: zookeeper, hdfs infra solr, infra manager, logsearch
  2. Enable archiving service logs and set the destination to Hdfs
  3. Start the archiver_service_logs job using Infra Manager rest api
  4. Check the files permission on hdfs in the specified destination directory

@kasakrisz kasakrisz added enhancement New feature or request security labels Oct 26, 2018
@kasakrisz kasakrisz self-assigned this Oct 26, 2018
@asfgit
Copy link

asfgit commented Oct 26, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Infra-Github-PR-Builder/15/
Test PASSed.

@asfgit
Copy link

asfgit commented Oct 26, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Infra-Github-PR-Builder/16/
Test PASSed.

adoroszlai
adoroszlai approved these changes Oct 26, 2018
View reviewed changes
...ra-manager/src/test/java/org/apache/ambari/infra/json/FsPermissionToStringConverterTest.java
import org.junit.Test;

/*
* Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems misplaced, usually the license is at the top of files, although this does not cause RAT failure.

@asfgit
Copy link

asfgit commented Oct 29, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Infra-Github-PR-Builder/17/
Test PASSed.

oleewere
oleewere approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@oleewere oleewere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oleewere oleewere merged commit 7f3a744 into apache:master Oct 29, 2018
@kasakrisz kasakrisz mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleewere oleewere oleewere approved these changes

@adoroszlai adoroszlai adoroszlai approved these changes

@swagle swagle Awaiting requested review from swagle

Assignees

@kasakrisz kasakrisz

Labels
enhancement New feature or request security
Projects
None yet
Milestone
No milestone
4 participants
@kasakrisz @asfgit @oleewere @adoroszlai