AMBARI-24838 - Infra Manager: zookeper connection string #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
adoroszlai
approved these changes
Oct 29, 2018
| CloudSolrClient client = new CloudSolrClient.Builder().withZkHost(zooKeeperConnectionString).build(); | ||
| ConnectStringParser connectStringParser = new ConnectStringParser(zooKeeperConnectionString); | ||
| CloudSolrClient client = new CloudSolrClient.Builder( | ||
| connectStringParser.getServerAddresses().stream().map(InetSocketAddress::toString).collect(Collectors.toList()), |
There was a problem hiding this comment.
I think extracting the result of this stream operation to a local variable would improve readability.
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Infra Manager can not connect to zookeeper if it is installed into a node where there is no zookeeper server instance.
The builder which is used for construct an org.apache.solr.client.solrj.impl.CloudSolrClient instance is deprecated: it does not handle the zookeper connection string fromat which sould be set in the stack code.
How was this patch tested?
ITs passed
Manually: