AMBARI-24833. Create cloud input/output skeleton. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasakrisz
reviewed
Oct 31, 2018
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederMode.java
Outdated
Show resolved
Hide resolved
kasakrisz
reviewed
Oct 31, 2018
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
Outdated
Show resolved
Hide resolved
kasakrisz
reviewed
Oct 31, 2018
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
Outdated
Show resolved
Hide resolved
kasakrisz
reviewed
Oct 31, 2018
...java/org/apache/ambari/logfeeder/manager/operations/impl/CloudStorageInputConfigHandler.java
Show resolved
Hide resolved
kasakrisz
reviewed
Oct 31, 2018
...main/java/org/apache/ambari/logfeeder/manager/operations/impl/DefaultInputConfigHandler.java
Show resolved
Hide resolved
kasakrisz
reviewed
Oct 31, 2018
...main/java/org/apache/ambari/logfeeder/manager/operations/impl/DefaultInputConfigHandler.java
Show resolved
Hide resolved
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
kasakrisz
reviewed
Oct 31, 2018
| FileUtils.writeStringToFile(pwdFile, defaultSecret, Charset.defaultCharset()); | ||
| return defaultSecret.toCharArray(); | ||
| } else { | ||
| return FileUtils.readFileToString(pwdFile, Charset.defaultCharset()).toCharArray(); |
There was a problem hiding this comment.
File content can be read directly to byte or char array That would be more secure than readFileToString. Also defaultSecret can be a char[]
kasakrisz
approved these changes
Oct 31, 2018
oleewere
added a commit
that referenced
this pull request
Nov 19, 2018
* AMBARI-24833. Create cloud input/output skeleton. * AMBARI-24833. Use LogFeederMode as enum by spring * AMBARI-24833. Fix review issues + add secret stores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
both mode can work independently from each other (see the Conditional beans in ApplicationConfig)
How was this patch tested?
with docker env by changing the default cloud mode