Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMBARI-25864: Fix an unit test failure on ambari-metrics-common #102

Merged
merged 1 commit into from Feb 24, 2023
Merged

AMBARI-25864: Fix an unit test failure on ambari-metrics-common #102

merged 1 commit into from Feb 24, 2023

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Feb 24, 2023

What changes were proposed in this pull request?

Fix unit test failure on ambari-metrics-common due to the lack of a dependency.

How was this patch tested?

Ran the following command locally.

$ mvn clean test -f ambari-metrics-common/pom.xml

...

Results :

Tests run: 20, Failures: 0, Errors: 0, Skipped: 0

...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  36.588 s
[INFO] Finished at: 2023-02-24T15:17:23+09:00
[INFO] ------------------------------------------------------------------------

@sekikn sekikn requested a review from kevinw66 February 24, 2023 07:31
kevinw66
kevinw66 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @sekikn

@kevinw66 kevinw66 merged commit 58fe89e into apache:master Feb 24, 2023
kevinw66 pushed a commit to kevinw66/ambari-metrics that referenced this pull request Feb 24, 2023
@sekikn @kevinw66
AMBARI-25864: Fix an unit test failure on ambari-metrics-common (apac…
385f999 
…he#102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinw66 kevinw66 kevinw66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sekikn @kevinw66