Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-25876: Bump version to 3.0.0-SNAPSHOT #108

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

kevinw66
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@sekikn
Copy link
Contributor

sekikn commented Feb 28, 2023

+1, ensured that all version numbers in the code were updated and mvn clean install -Dbuild-rpm was successful on CentOS 7. Thanks @kevinw66!

$ rpm -qip ambari-metrics-assembly/target/rpm/ambari-metrics-collector/RPMS/x86_64/ambari-metrics-collector-3.0.0-SNAPSHOT.x86_64.rpm 
Name        : ambari-metrics-collector
Version     : 3.0.0
Release     : SNAPSHOT
...

@sekikn sekikn merged commit fea1f7f into apache:master Feb 28, 2023
@virajjasani
Copy link

I thought we wanted to go with 2.8.0? But 3.0.0 is fine too since we don't have any released version numbers closer to 3.0.0.

Besides, Ambari 2.8.0 would be the first release with ambari-metrics getting released separately, correct?

@kevinw66
Copy link
Contributor Author

kevinw66 commented Mar 1, 2023

I thought we wanted to go with 2.8.0? But 3.0.0 is fine too since we don't have any released version numbers closer to 3.0.0.

@virajjasani Since we change the format of the version number, upgrade major version might be better I think.

Besides, Ambari 2.8.0 would be the first release with ambari-metrics getting released separately, correct?

Yes.

@virajjasani
Copy link

Sounds good, thanks @kevinw66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants