AMBARI-25963: Metrics metadata sync problem, accessing metrics which got created though other collector throws NPE #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajjasani
reviewed
Jun 29, 2023
Thanks @virajjasani for review. Added validation for this issue scenario in an existing test case TestMetadataSync#testRefreshMetadataOnWrite |
virajjasani
approved these changes
Jul 5, 2023
|
@arshadmohammad thanks reporting, Can you squash the commit so that jira number will reflect..? And can you raise for branch-2.7 also. |
…got created though other collector throws NPE
arshadmohammad
force-pushed
the
metricsMetaSync
branch
from
1fe0316
to
eef2b7a
Compare
squashed the commits, raised PR for branch-2.7 |
|
+1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When metrics are synced from other collectors, update the uuid metrics metadata map as well.
How was this patch tested?
Tested the scenario mentioned the jira before and after the fix. Fix was verified by applying the changes on existing cluster
Please review Ambari Contributing Guide before opening a pull request.