Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Flink]: Support all logstore configuration items to be configured in table properties #933

Closed
2 of 3 tasks
zstraw opened this issue Dec 14, 2022 · 2 comments · Fixed by #970
Closed
2 of 3 tasks
Labels
module:mixed-flink Flink moduel for Mixed Format type:improvement
Milestone

Comments

@zstraw
Copy link
Contributor

zstraw commented Dec 14, 2022

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Now log-store configuration was doced in table properties. But some config is invalid in table which should be set in flink sql hint.
It's necessary to uniformly manage all log-store properties in table.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

@zstraw zstraw added module:mixed-flink Flink moduel for Mixed Format type:improvement labels Dec 14, 2022
@YesOrNo828
Copy link
Contributor

YesOrNo828 commented Dec 15, 2022

@zstraw Could you share some example properties which are invalid via the flink SQL hint?

@zstraw
Copy link
Contributor Author

zstraw commented Dec 15, 2022

@zstraw Could you share some example properties which are invalid via the flink SQL hint?

As I known, 'log-store.consistency-guarantee.enabled' and 'log.consumer.changelog.modes' are invalid in table properties, not invalid in flink sql hint.

@YesOrNo828 YesOrNo828 changed the title [Improvement][Flink]: support all log-store config in table properties. [Improvement][Flink]: Support all logstore configuration items to be configured in table properties Dec 20, 2022
@YesOrNo828 YesOrNo828 added this to the Release 0.4.1 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format type:improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants