[ARCTIC-969] Refactor Logstore Source to FLINK FLIP-27 API #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YesOrNo828
changed the title
YesOrNo828
reviewed
Dec 30, 2022
There was a problem hiding this comment.
@zstraw Thanks a lot for driving this. I left some comments.
And I would suggest that the legacy logstore datastream API should be deprecated after a period of time, maybe after two versions are released, we can then remove these codes because we want to give some buffer time for those who already use these APIs, and adapt the new Source API. WDYT?
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/read/source/log/LogKafkaSource.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/read/source/log/LogKafkaSource.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/read/source/log/LogKafkaSource.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/read/source/log/LogKafkaSource.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/read/source/log/LogKafkaSource.java
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/table/LogDynamicSource.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/table/LogDynamicSource.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/table/LogDynamicSource.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/table/LogDynamicSource.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/table/LogDynamicSource.java
Outdated
Show resolved
Hide resolved
zstraw
force-pushed
the
log-flip27
branch
2 times, most recently
from
694aad9
to
33af8d5
Compare
YesOrNo828
reviewed
Jan 9, 2023
flink/v1.12/flink/src/main/java/com/netease/arctic/flink/read/source/log/LogKafkaSource.java
Outdated
Show resolved
Hide resolved
...1.12/flink/src/main/java/com/netease/arctic/flink/read/source/log/LogKafkaSourceBuilder.java
Outdated
Show resolved
Hide resolved
|
@zstraw Please also update the Flink datastream documentation: site/docs/ch/flink/flink-ds.md |
github-actions
bot
added
the
type:docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Refactor log source and sink to support Flink Flip-27 source API, which would be helpful to read file and log integrately, and Pulsar log.
Fix #482
Resolve #933
Resolve #969
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation