Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARCTIC-985] remove the useless expiration process of table_transaction_meta #1064

Merged
merged 2 commits into from
Feb 8, 2023
Merged

[ARCTIC-985] remove the useless expiration process of table_transaction_meta #1064

merged 2 commits into from
Feb 8, 2023

Conversation

wangtaohz
Copy link
Contributor

Why are the changes needed?

table_transaction_meta in sysdb is useless now, its expiration process should be removed

Brief change log

  • remove the useless expiration process of table_transaction_meta
  • catch all exceptions of RuntimeDataExpireService and add some error log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Feb 7, 2023
@wangtaohz
Copy link
Contributor Author

table_transaction_meta could be removed from sysdb after ams upgrade to 0.4.1.

However, it should be removed in the upgrade-0.4.0-to-0.4.1.sql, since these sqls are run before the upgrade.

Aireed
Aireed approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@Aireed Aireed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aireed Aireed merged commit bc89552 into apache:master Feb 8, 2023
@wangtaohz wangtaohz deleted the fix-985-2 branch February 8, 2023 01:48
wangtaohz added a commit that referenced this pull request Feb 8, 2023
@wangtaohz
[ARCTIC-985] remove the useless expiration process of `table_transact…
75fc9d7 
…ion_meta` (#1064)

* remove the expire of table_transaction_meta

* fix compile error

(cherry picked from commit bc89552)
Signed-off-by: wangtao <wangtao3@corp.netease.com>
This was referenced Apr 21, 2023
Open
Closed
zhoujinsong pushed a commit that referenced this pull request May 31, 2023
@wangtaohz
[ARCTIC-985] remove the useless expiration process of `table_transact…
4daff38 
…ion_meta` (#1064)

* remove the expire of table_transaction_meta

* fix compile error
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
@wangtaohz @ShawHee
[ARCTIC-985] remove the useless expiration process of `table_transact…
ea276cc 
…ion_meta` (apache#1064)

* remove the expire of table_transaction_meta

* fix compile error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aireed Aireed Aireed approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wangtaohz @Aireed