[ARCTIC-1171][FLINK] When reading partial fields from Logstore, the number of fields does not match #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklhdu
changed the title
YesOrNo828
reviewed
Mar 1, 2023
There was a problem hiding this comment.
@lklhdu Generally speaking, this patch is ok, there is a small place that needs to modify.
| @@ -150,6 +162,14 @@ protected LogPulsarSource createPulsarSource() { | |||
| projectedSchema = new Schema(Arrays.stream(valueProjection).mapToObj(columns::get).collect(Collectors.toList())); | |||
| } | |||
|
|
|||
| if (projectedFields != null) { | |||
There was a problem hiding this comment.
How about abstracting the common logic to a private method?
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
…umber of fields does not match (#1172) LogDynamicSource support projected push down.
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…umber of fields does not match (apache#1172) LogDynamicSource support projected push down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #1171
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation