[ARCTIC-1295] fix writing into an empty KeyedTable with flink/spark 0.3.x/0.4.0 and AMS 0.4.1 #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:ams-server
wangtaohz
added
priority:critical
and removed
module:ams-server
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1296 +/- ##
=============================================
- Coverage 52.65% 28.02% -24.64%
- Complexity 522 4865 +4343
=============================================
Files 43 652 +609
Lines 3705 67116 +63411
Branches 354 7821 +7467
=============================================
+ Hits 1951 18811 +16860
- Misses 1623 46426 +44803
- Partials 131 1879 +1748
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 692 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
module:ams-server
This was referenced Apr 21, 2023
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
….3.x/0.4.0 and AMS 0.4.1 (#1296) * table with currentTxId == 0 shoule be valid for allocate TxId from AMS * valid/invalid KeyedTable for allocating transaction id after table created/dropped
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
….3.x/0.4.0 and AMS 0.4.1 (apache#1296) * table with currentTxId == 0 shoule be valid for allocate TxId from AMS * valid/invalid KeyedTable for allocating transaction id after table created/dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #1295
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation