Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2165] Struct correct partition aliases from table schema #2166

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

XBaith
Copy link
Contributor

@XBaith XBaith commented Oct 21, 2023

Why are the changes needed?

Close #2165.

Brief change log

  • avoid npe when fresh tables

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:core Core module label Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...java/com/netease/arctic/utils/ArcticDataFiles.java 65.07% <100.00%> (ø)

... and 498 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit ed950bb into apache:master Oct 23, 2023
6 checks passed
@XBaith XBaith deleted the fix-partition-name-bug branch October 23, 2023 12:46
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
…he#2166)

* partition field name struct issue

* spotless

---------

Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:core Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Get incorrect partition field name when refresh tables
2 participants