Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix]Delete sync tables when drop external catalogs #2235

Merged
merged 9 commits into from
Nov 3, 2023

Conversation

shidayang
Copy link
Contributor

Why are the changes needed?

When an external catalog is deleted, the tables synchronized from the external catalog should be deleted together.

Brief change log

  • Modify DefaultTableService dropCatalog method

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...m/netease/arctic/server/catalog/ServerCatalog.java 100.00% <100.00%> (ø)
...tease/arctic/server/table/DefaultTableService.java 83.38% <75.00%> (-4.74%) ⬇️

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shidayang shidayang added this to the Release 0.6.0 milestone Nov 2, 2023
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shidayang shidayang mentioned this pull request Nov 3, 2023
70 tasks
@shidayang shidayang merged commit ab961c2 into apache:master Nov 3, 2023
5 of 6 checks passed
@shidayang shidayang deleted the delete-tables-when-drop-catalogs branch November 3, 2023 07:04
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants