Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-2276]: UnifiiedCatalog for Spark Engine #2269

Merged
merged 36 commits into from
Dec 12, 2023

fix review comments

2f18c81
Select commit
Loading
Failed to load commit list.
Merged

[AMORO-2276]: UnifiiedCatalog for Spark Engine #2269

fix review comments
2f18c81
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 12, 2023 in 1s

52.80% (-0.74%) compared to efe8ae7

View this Pull Request on Codecov

52.80% (-0.74%) compared to efe8ae7

Details

Codecov Report

Attention: 411 lines in your changes are missing coverage. Please review.

Comparison is base (efe8ae7) 53.53% compared to head (2f18c81) 52.80%.
Report is 3 commits behind head on master.

Files Patch % Lines
.../com/netease/arctic/spark/SparkUnifiedCatalog.java 0.00% 144 Missing ⚠️
...ease/arctic/spark/mixed/MixedSparkCatalogBase.java 0.00% 89 Missing ⚠️
...a/com/netease/arctic/spark/SessionCatalogBase.java 0.00% 65 Missing ⚠️
.../java/com/netease/arctic/spark/util/SparkUtil.java 0.00% 27 Missing ⚠️
...tease/arctic/spark/SparkUnifiedSessionCatalog.java 0.00% 24 Missing ⚠️
...tease/arctic/spark/iceberg/IcebergSparkFormat.java 0.00% 10 Missing ⚠️
...tease/arctic/spark/mixed/MixedFormatSparkUtil.java 0.00% 9 Missing ⚠️
...se/arctic/spark/mixed/MixedSessionCatalogBase.java 0.00% 8 Missing ⚠️
...etease/arctic/spark/mixed/MixedTableStoreType.java 0.00% 5 Missing ⚠️
.../java/com/netease/arctic/CommonUnifiedCatalog.java 55.55% 4 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2269      +/-   ##
============================================
- Coverage     53.53%   52.80%   -0.74%     
- Complexity     4367     4371       +4     
============================================
  Files           517      533      +16     
  Lines         29877    30317     +440     
  Branches       2910     2962      +52     
============================================
+ Hits          15996    16008      +12     
- Misses        12593    13023     +430     
+ Partials       1288     1286       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov