[BugFix][Spark]: Add default value of table-filters in spark scan builder to avoid NPE when comparing the table scan. #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2313 +/- ##
============================================
+ Coverage 52.68% 52.94% +0.25%
+ Complexity 4208 3612 -596
============================================
Files 511 465 -46
Lines 29263 24502 -4761
Branches 2860 2340 -520
============================================
- Hits 15418 12973 -2445
+ Misses 12592 10510 -2082
+ Partials 1253 1019 -234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can we check the |
Fixed |
baiyangtx
changed the title
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…lder to avoid NPE when comparing the table scan. (apache#2313) * fix npe problem when scan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The NPE may be throwed when spark comparing the table scan during plan.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation