Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix deleting Puffin files when cleaning orphan files #2320

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

wangtaohz
Copy link
Contributor

Why are the changes needed?

The puffin files are in the data/puffin location which should also be protected when cleaning the data files.

Brief change log

  • should not delete Puffin files when cleaning orphan files

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d48c0e0) 52.94% compared to head (8fdad6c) 52.70%.

Files Patch % Lines
.../optimizing/maintainer/IcebergTableMaintainer.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2320      +/-   ##
============================================
- Coverage     52.94%   52.70%   -0.25%     
- Complexity     3612     4207     +595     
============================================
  Files           465      511      +46     
  Lines         24502    29275    +4773     
  Branches       2340     2859     +519     
============================================
+ Hits          12973    15428    +2455     
- Misses        10510    12594    +2084     
- Partials       1019     1253     +234     
Flag Coverage Δ
core 52.98% <88.00%> (+0.03%) ⬆️
trino 51.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit b1eb9f4 into apache:master Nov 20, 2023
5 of 6 checks passed
@wangtaohz wangtaohz deleted the hotfix branch November 20, 2023 09:04
@zhoujinsong zhoujinsong mentioned this pull request Dec 19, 2023
33 tasks
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
…#2320)

* fix orphan files deleting puffin files

* using Sets.union instead of ImmutableSet Builder

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants