[AMORO-1747] Ban guava direct import when building #2679
Conversation
github-actions
bot
added
module:mixed-flink
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2679 +/- ##
============================================
- Coverage 34.03% 34.02% -0.01%
+ Complexity 4363 4362 -1
============================================
Files 604 604
Lines 50748 50748
Branches 6671 6671
============================================
- Hits 17270 17267 -3
- Misses 32078 32080 +2
- Partials 1400 1401 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klion26
force-pushed
the
ban_guava_import
branch
from
22fde02
to
f305eeb
Compare
klion26
force-pushed
the
ban_guava_import
branch
from
f305eeb
to
e6ae0e1
Compare
There was a problem hiding this comment.
Thanks for your contribution.
I found some that didn't use shade class because it was suppressed in suppressions.xml.
e.g.
com.netease.arctic.api.config.OptimizingConfig
&& com.google.common.base.Objects.equal(optimizerGroup, that.optimizerGroup);
com.netease.arctic.api.metrics.MetricKey
import com.google.common.collect.ImmutableMap;
...
com.netease.arctic.server.dashboard.controller.OptimizerController
import com.google.common.base.Preconditions;
...
|
@zhongqishang thanks for the review. The suppressions ware introduced by #2671, and intended to be modified in #2675. I can also modify these if we need to change all guava import in this PR |
klion26
force-pushed
the
ban_guava_import
branch
from
e34ba71
to
501945f
Compare
klion26
force-pushed
the
ban_guava_import
branch
2 times, most recently
from
e5b6594
to
42a8d48
Compare
|
kindly ping @zhongqishang @zhoujinsong |
klion26
force-pushed
the
ban_guava_import
branch
from
42a8d48
to
fd2b4f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2679 +/- ##
============================================
- Coverage 34.02% 34.02% -0.01%
Complexity 4364 4364
============================================
Files 604 604
Lines 50754 50752 -2
Branches 6673 6673
============================================
- Hits 17269 17268 -1
+ Misses 32086 32085 -1
Partials 1399 1399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@klion26 Thanks a lot for your contribution! |
|
@zhoujinsong @zhongqishang @majin1102 thanks a lot for the review and merging! |
* [AMORO-1747] Ban guava direct import when building * spotless:apply for trino mixed format * fix can find class * fix all invalid guava import --------- resolve conflicts use iceberg-relocated Co-authored-by: Qishang Zhong <zhongqishang@gmail.com> (cherry picked from commit 0c5a173)
Why are the changes needed?
Close #1747.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation