Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change package name for module mixed-format/flink #2750

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Change package name for module mixed-format/flink #2750

merged 3 commits into from
Apr 16, 2024

Conversation

zhoujinsong
Copy link
Contributor

Why are the changes needed?

Change package name to org.apache.amoro for mixed-format/flink modules.

Brief change log

  • Change package name.
  • Change related docs.
  • Change related configuration files.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@zhoujinsong zhoujinsong changed the title Change package name in module mixed-format/flink Change package name for module mixed-format/flink Apr 16, 2024
@github-actions github-actions bot added type:docs Improvements or additions to documentation module:mixed-flink Flink moduel for Mixed Format labels Apr 16, 2024
@zhongqishang zhongqishang mentioned this pull request Apr 16, 2024
Open
12 tasks
@zhoujinsong
Merge pull request #1 from zhongqishang/fix-shade-id
75326a7 
[Hotfix] Fix shade plugin id and artifactId
zhongqishang
zhongqishang approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@zhongqishang zhongqishang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 4c8e8d9 into apache:master Apr 16, 2024
4 checks passed
@zhoujinsong zhoujinsong deleted the change-flink-package branch April 16, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongqishang zhongqishang zhongqishang approved these changes

@xleoken xleoken xleoken approved these changes

Assignees
No one assigned
Labels
module:mixed-flink Flink moduel for Mixed Format type:build type:docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhoujinsong @zhongqishang @xleoken