[AMORO-2778][Helm Chart] Add Tests for Helm Chart #2794
Conversation
|
@baiyangtx Could you please help to review? |
|
|
||
| Helm Chart for Amoro supports Unit Tests by [helm-unittest](https://github.com/helm-unittest/helm-unittest). Before | ||
| submitting PRs, please let all the tests passed . |
There was a problem hiding this comment.
please let all tests passed.
| appVersion: 0.1.0 | ||
| version: 0.6.0 | ||
| tests: | ||
| - it: Amoro database secret should not exist when database type set to derby |
There was a problem hiding this comment.
when database type is set to derby
| asserts: | ||
| - hasDocuments: | ||
| count: 0 | ||
| - it: Amoro database secret should exist when database type set to mysql |
There was a problem hiding this comment.
when database type is set to mysql
There was a problem hiding this comment.
Some similar contents in this file can be changed
| asserts: | ||
| - notExists: | ||
| path: metadata.annotations | ||
| - it: Amoro Ingress should not contains ingress className if not set |
There was a problem hiding this comment.
Amoro Ingress should not contain ingress className if not set.
| documentSelector: | ||
| path: metadata.name | ||
| value: test-table | ||
| - it: Amoro Service for table should reflect Node port of set type to NodePort |
There was a problem hiding this comment.
type is set to NodePort
…orkflow to run unittest when aubmit pr
Thanks for your advice. I have add a workflow to run unit tests when change helm chart files. Could you help to check if it is proper? |
| # This workflow will execute Tests when submit a PR. | ||
|
|
||
| name: "Pull Request Test For Helm Charts" | ||
|
|
There was a problem hiding this comment.
Add this
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Co-authored-by: baiyangtx <xiangnebula@163.com>
|
Thanks again. I have accepted all the suggestions. Is there another one? |
Why are the changes needed?
Fix #2778
Brief change log
app.kubernetes.io/name: amoro-database-secretin "charts/amoro/templates/amoro-database-secert.yaml"How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation