Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1744] Rename name with arctic identifier in amoro-mixed-format-flink module #2848

Conversation

zhoujinsong
Copy link
Contributor

Why are the changes needed?

As titled.

Brief change log

  • Change the name of classes with the arctic identifier.
  • Change the name of variables and methods with the arctic identifier.
  • Change the comments with the arctic identifier.
  • Change related documentation.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added type:docs Improvements or additions to documentation module:mixed-flink Flink moduel for Mixed Format labels May 20, 2024
@xleoken
Copy link
Member

xleoken commented May 20, 2024

👍

Copy link
Contributor

@YesOrNo828 YesOrNo828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.78%. Comparing base (a2753b6) to head (07a99a8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2848      +/-   ##
============================================
- Coverage     35.95%   32.78%   -3.17%     
- Complexity      383     3822    +3439     
============================================
  Files            45      558     +513     
  Lines          4700    46292   +41592     
  Branches        513     6177    +5664     
============================================
+ Hits           1690    15178   +13488     
- Misses         2842    29920   +27078     
- Partials        168     1194    +1026     
Flag Coverage Δ
core 32.78% <ø> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xieyi888
Copy link
Contributor

👍

@zhoujinsong zhoujinsong merged commit cb2b996 into apache:master May 21, 2024
3 checks passed
@zhoujinsong zhoujinsong deleted the change-mixed-format-flink-arctic-identifier branch May 21, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants