Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix apache rat check errors #2952

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

zhoujinsong
Copy link
Contributor

Why are the changes needed?

As titled.

Brief change log

  • Add copyright header for charts/amoro/templates/amoro-admin-secret.yaml

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@XBaith
Copy link
Contributor

XBaith commented Jun 20, 2024

Thanks!
Can we also rename the Secrets? The database secrets file has the same name as the admin's

@XBaith
Copy link
Contributor

XBaith commented Jun 20, 2024

Thanks! Can we also rename the Secrets? The database secrets file has the same name as the admin's

Or rename properties. For example: username to adminUsername, password to adminPassword

@zhoujinsong
Copy link
Contributor Author

Or rename properties. For example: username to adminUsername, password to adminPassword

I have renamed some secrets and modified configmap as we discussed in #2948

Copy link
Contributor

@XBaith XBaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@zhoujinsong zhoujinsong merged commit 15e2471 into apache:master Jun 20, 2024
2 checks passed
@zhoujinsong zhoujinsong deleted the fix-rat-check branch June 20, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants