Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2977]Mixed-Format Unkeyed Table will read the full amount of data even if configured with 'scan.startup.mode'='latest' #2978

Merged
merged 7 commits into from
Jul 4, 2024

Conversation

lklhdu
Copy link
Contributor

@lklhdu lklhdu commented Jun 28, 2024

Why are the changes needed?

Fix #2977.

Brief change log

  • When 'scan.startup.mode'='latest' is configured, read the unkeyed amoro table of type mixed-format based on the current snapshot ID

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:mixed-flink Flink moduel for Mixed Format label Jun 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.83%. Comparing base (bdd798c) to head (24e44b3).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2978      +/-   ##
============================================
- Coverage     32.85%   32.83%   -0.02%     
- Complexity     3822     3824       +2     
============================================
  Files           557      557              
  Lines         46184    46226      +42     
  Branches       6099     6107       +8     
============================================
+ Hits          15173    15180       +7     
- Misses        29818    29852      +34     
- Partials       1193     1194       +1     
Flag Coverage Δ
core 32.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lklhdu lklhdu changed the title [Draft][AMORO-2977]Mixed-Format Unkeyed Table will read the full amount of data even if configured with 'scan.startup.mode'='latest' [AMORO-2977]Mixed-Format Unkeyed Table will read the full amount of data even if configured with 'scan.startup.mode'='latest' Jun 30, 2024
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!

@zhoujinsong zhoujinsong merged commit 5a40884 into apache:master Jul 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format
Projects
None yet
4 participants