[ARCTIC-495]remove unnecessary properties when sync and commit properties to ams #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoujinsong
requested changes
Oct 20, 2022
| @@ -47,5 +48,14 @@ public class ServerTableProperties { | |||
| HIDDEN_EXPOSED.add(TableProperties.READ_DISTRIBUTION_MODE_HASH); | |||
| HIDDEN_EXPOSED.add(TableProperties.PROTECTED_PROPERTIES.toString()); | |||
| HIDDEN_EXPOSED.add(TableProperties.TABLE_EVENT_TIME_FIELD); | |||
|
|
|||
| HIDDEN_INTERNAL.add("meta_store_site"); | |||
There was a problem hiding this comment.
Could change these value with constant variables?
There was a problem hiding this comment.
Should we add a CatalogProperties class in core module?
| @@ -303,6 +305,8 @@ public void syncDDl(ArcticTable arcticTable) { | |||
|
|
|||
| public void syncProperties(TableMetadata tableMetadata, ArcticTable arcticTable) { | |||
| Table table = arcticTable.isKeyedTable() ? arcticTable.asKeyedTable().baseTable() : arcticTable.asUnkeyedTable(); | |||
| PropertiesUtil.removeHiddenProperties(tableMetadata.getProperties(), ServerTableProperties.HIDDEN_INTERNAL); | |||
There was a problem hiding this comment.
This map is an immutable map, can not execute remove operation
There was a problem hiding this comment.
fixed in new commit
hzluting
pushed a commit
to hzluting/arctic
that referenced
this pull request
Oct 20, 2022
…ties to ams (apache#496) * remove unnecessary properties when sync and commit properties to ams * fix immutable map can not remove and add unit test * fix code style * change log
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
…ties to ams (#496) * remove unnecessary properties when sync and commit properties to ams * fix immutable map can not remove and add unit test * fix code style * change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
resolve #495
remove unnecessary properties when sync and commit properties to ams
Brief change log
remove unnecessary properties when sync and commit properties to ams
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation