Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCTIC-497] fix When adding cloumn to keyed hive table with partitions, the scheam sequence of change table and base table is different #501

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

hameizi
Copy link
Contributor

@hameizi hameizi commented Oct 20, 2022

Why are the changes needed?

resolve #497

Brief change log

add HiveChangeInternalTable and BaseSchemaUpdate

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@hameizi hameizi changed the title [ARCTIC-497]add HiveChangeInternalTable and BaseSchemaUpdate [ARCTIC-497] fix When adding cloumn to keyed hive table with partitions, the scheam sequence of change table and base table is different Oct 20, 2022
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 5a7c908 into apache:master Oct 20, 2022
zhoujinsong pushed a commit that referenced this pull request Oct 20, 2022
…ns, the scheam sequence of change table and base table is different (#501)

* add HiveChangeInternalTable and BaseSchemaUpdate

* fix code style
zhoujinsong pushed a commit that referenced this pull request May 31, 2023
…ns, the scheam sequence of change table and base table is different (#501)

* add HiveChangeInternalTable and BaseSchemaUpdate

* fix code style
@hameizi hameizi deleted the resolve-497 branch July 7, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants