Skip to content

Commit

Permalink
change the default of authenticateOnRedirect
Browse files Browse the repository at this point in the history
  • Loading branch information
bodewig committed Dec 23, 2021
1 parent 492c2c1 commit 82f5edc
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
14 changes: 9 additions & 5 deletions WHATSNEW
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
Changes from Ant 1.10.12 TO Ant 1.10.13
=======================================

Changes that could break older environments:
-------------------------------------------

* <get> has a new attribute authenticateOnRedirect that can be used to
prevent Ant from sending the configured credentials when following a
redirect. It is false by default, which means builds that rely on
credentials being used on the redirected URI may break.
Github Pull Request #173

Other changes:
--------------

Expand All @@ -16,11 +25,6 @@ Other changes:
* <ftp> now supports FTPs.
Github Pull Request #170

* <get> has a new attribute authenticateOnRedirect that can be used to
prevent Ant from sending the configured credentials when following a
redirect. It is true by default for backwards compatibility reasons.
Github Pull Request #173

Changes from Ant 1.10.11 TO Ant 1.10.12
=======================================

Expand Down
2 changes: 1 addition & 1 deletion manual/Tasks/get.html
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ <h3>Parameters</h3>
<td>authenticateOnRedirect</td>
<td>Whether the credentials should also be sent to the new location when a redirect is followed.<br/>
<em>since Ant 1.10.13</em></td>
<td>No; default is <q>true</q></td>
<td>No; default is <q>false</q></td>
</tr>
<tr>
<td>maxtime</td>
Expand Down
2 changes: 1 addition & 1 deletion src/main/org/apache/tools/ant/taskdefs/Get.java
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public class Get extends Task {
private boolean ignoreErrors = false;
private String uname = null;
private String pword = null;
private boolean authenticateOnRedirect = true; // on by default for backward compatibility
private boolean authenticateOnRedirect = false;
private long maxTime = 0;
private int numberRetries = NUMBER_RETRIES;
private boolean skipExisting = false;
Expand Down

0 comments on commit 82f5edc

Please sign in to comment.