Bug 58661: avoid duplicate characters in stack traces #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that $secondhalflen is actually less than string-length($secondhalfword) in case the number of chars in word is even. This leads to $firsthalflen being calculated too long, resulting in a duplicated character.
|
Thanks a lot. I vaguely recall looking at the original patch and thinking "this is big", but strangely never commented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=58661
As suspected, the problem is in the 'br-replace' template that is off by one character in some cases:
$secondhalflen is actually less than string-length($secondhalfword) in case the number of chars in word is
even. This leads to $firsthalflen being calculated too long, resulting in a duplicated character.
Note that unlike the patch attached to the bug, this pull requests solves just the duplicate character problem - nothing else.