Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use equals method of a string literal to prevent NPE and isEmpty() me… #56

Closed
wants to merge 1 commit into from

Conversation

reudismam
Copy link
Contributor

…thod instead of comparing a String object with an empty string.

This change has already been done for some locations in the commit:
b7d1e9b

…thod instead of comparing a String object with an empty string.
@asfgit
Copy link

asfgit commented Feb 1, 2018

Can one of the admins verify this patch?

3 similar comments
@asfgit
Copy link

asfgit commented Feb 1, 2018

Can one of the admins verify this patch?

@asfgit
Copy link

asfgit commented Feb 1, 2018

Can one of the admins verify this patch?

@asfgit
Copy link

asfgit commented Feb 1, 2018

Can one of the admins verify this patch?

@jaikiran
Copy link
Member

jaikiran commented Feb 2, 2018

this is ok to test

@asfgit
Copy link

asfgit commented Feb 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/36/

@asfgit
Copy link

asfgit commented Feb 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/30/

asfgit pushed a commit that referenced this pull request Feb 2, 2018
this is a stripped down version of #56 as `isEmpty` is not available
in Java5.
@asfgit asfgit closed this in 32d178f Feb 2, 2018
@bodewig
Copy link
Member

bodewig commented Feb 2, 2018

many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants