Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

ANY23-351 fixed NullPointerException in HCardExtractor #86

Merged
merged 1 commit into from Jun 27, 2018
Merged

ANY23-351 fixed NullPointerException in HCardExtractor #86

merged 1 commit into from Jun 27, 2018

Conversation

HansBrende
Copy link
Member

This PR:

  1. fixes the NullPointerExceptions that have occurred in HCardExtractor
  2. supports the 'srcset' attribute in obtaining urls from img elements
  3. fixes the fallback url extraction method to align with the spec by only obtaining url text from 'value'-class elements, or, if none defined, from non-'type'-class elements.

mvn clean test -> all tests pass

@HansBrende
Copy link
Member Author

@lewismc any comments?

@lewismc
Copy link
Member

lewismc commented Jun 27, 2018

Pull PR and tested locally. I've inspected it and have no comments for improvement. +1 from me.

@asfgit asfgit merged commit 31e1142 into apache:master Jun 27, 2018
@HansBrende HansBrende deleted the ANY23-351 branch June 27, 2018 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@HansBrende @lewismc @asfgit