This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
- APEX-256 Added unit tests to verify that checkpointed is or is not … #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…called immediately after triggering a copyToHDFS for the different processing modes for asynchronous checkpointing.
|
@gauravgopi123 Please review |
| public org.junit.runner.Description desc; | ||
|
|
||
| public String getDir() | ||
| { |
There was a problem hiding this comment.
This method gets called twice for a test. Instead have a directory variable defined and initialize that variable with "target/" + desc.getClassName() + "/" + desc.getMethodName() in starting(). You don't need to store description variable
|
@ilooner can you please rebase and address the review comments? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…called immediately after triggering a copyToHDFS for the different processing modes for asynchronous checkpointing.