This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
APEXCORE-542 - Fix debug level verbose option for Apex cli. #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tushargosavi, @yogidevendra. Could you please review ? |
|
Looks fine to me. I will wait for couple of days for the feedback from other community members and then merge this. |
tushargosavi
reviewed
Oct 4, 2016
| * is INFO level. So overiding it to DEBUG level and threshold level for Console- | ||
| * appender is set through command line arguments. | ||
| */ | ||
| logger.setLevel(Level.DEBUG); |
There was a problem hiding this comment.
Can you set it to the verbose level, instead of setting it to debug for all cases?
There was a problem hiding this comment.
Thanks ! Done. Now it will override by logLevel specified by user through Apex Cli.
deepak-narkhede
force-pushed
the
APEXCORE-542-review
branch
from
cf3d5de
to
7186d29
Compare
deepak-narkhede
force-pushed
the
APEXCORE-542-review
branch
from
7186d29
to
33cf999
Compare
deepak-narkhede
force-pushed
the
APEXCORE-542-review
branch
from
33cf999
to
e1ada7e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fixes the debug level console logging for Apex cli.
The default logger level is INFO level for Apex cli. So even if we specify the threshold level as DEBUG for ConsoleAppender, the default parent level less that the Console Appender level. Hence it is not considered for logging.
Fix is that logger level is set to DEBUG initially and threshold level for ConsoleAppender is set as per the argument passed to Apex Cli.
Note: Current two appenders are used Event and Console Appenders.
For instrumentation details and unit testing please find the attached file.
Uploading apex-cli-debug-verbose-fix.log…
apex-cli-debug-verbose-fix.txt