This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
APEXCORE-496 Provide way for StatsListeners to get additional information #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozov
suggested changes
Feb 28, 2017
tushargosavi
force-pushed
the
APEXCORE-496
branch
from
8663e44
to
366c018
Compare
|
@vrozov I have removed checkstyle errors. |
tushargosavi
force-pushed
the
APEXCORE-496
branch
from
366c018
to
737c7e5
Compare
|
@tweise I have rebased the PR with current master |
tweise
reviewed
Jul 19, 2017
| @@ -1892,4 +1947,22 @@ public Integer getStreamCodecIdentifier(StreamCodec<?> streamCodecInfo) | |||
| return null; | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * A interface object for the statsListener to access the DAG, it provides methods | |||
There was a problem hiding this comment.
An interface for the {@link StatsListener} ... Please fix spelling and formatting of other Javadoc comments as well.
tweise
reviewed
Jul 19, 2017
| } | ||
|
|
||
| /** | ||
| * Adapter for handling deprecated StatsListener. This implementation calls {@see StatsListener.processStats(BatchedOperatorStats)} |
There was a problem hiding this comment.
The correct formatting would be {@link StatsListener#processStats(BatchedOperatorStats)}
tweise
suggested changes
Jul 21, 2017
| @@ -2246,4 +2253,97 @@ public void testParallelPartitionForSlidingWindow() | |||
| PhysicalPlan plan = new PhysicalPlan(dag, new TestPlanContext()); | |||
| Assert.assertEquals("number of containers", 7, plan.getContainers().size()); | |||
| } | |||
|
|
|||
| static class NoOpStatsListener implements StatsListener | |||
There was a problem hiding this comment.
could this be done with mockito?
There was a problem hiding this comment.
I will check with Mockito.
There was a problem hiding this comment.
I have use Mockito to mock the interface in the tests, and updated the pull request
tushargosavi
force-pushed
the
APEXCORE-496
branch
from
737c7e5
to
37308f3
Compare
|
@tweise I have handled the comments. |
tweise
approved these changes
Jul 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.