Preventing a scenario where more than one the subscribe notification task can be scheduled simultaneously #488
Conversation
… notification task can be scheduled simultaneously
|
It is OK to have more than one ListenersNotifier scheduled for execution. It follows at least one semantic. When there is data to send, there must be at least one ListenersNotifier running or scheduled for execution. The design goal is to prevent unlimited number of ListenersNotifier to be added to the ExecutionService queue for execution when Publisher is faster than Subscribers and have at least one when at least one subscriber still has data to send. Note that |
|
@PramodSSImmaneni Please close the PR if you agree that the synchronization is optional. |
|
@vrozov this doesn't need to block 3.6.0 and you can mark the JIRA resolved. There may still be validity to this as opposed to doing at-least once and it might give better performance. I need to look into this deeper to see if it does to justify the change. I will change the heading and leave it open till I can do that. |
pramodin
changed the title
|
@PramodSSImmaneni Every PR should have a JIRA associated with it. Please close the PR and open a new JIRA to discuss if proposed changes are necessary. |
|
Please file new JIRA and open new PR if this is still and issue. |
@vrozov please see. I missed this, something didnt feel right.