Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

APEXCORE-725 Example for configuring map properties. #529

Merged
merged 1 commit into from May 26, 2017

Conversation

tweise
Copy link
Contributor

@tweise tweise commented May 20, 2017

syntax. For example, the connection properties of the JDBC store can be accessed
like this:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdocs seems to render fenced code blocks better if the language is specified (xml in this instance) after the 3 backquotes. Without it we see some odd formatting with some words emboldened, others in a different color, etc. Maybe the 'xml' could also be added to the other blocks as well as appropriate.

@amberarrow
Copy link
Contributor

Ready to merge once the comment is addressed.

@tweise tweise force-pushed the APEXCORE-725-config branch 3 times, most recently from 4d938a8 to 78e491f Compare May 21, 2017 02:31
@tweise
Copy link
Contributor Author

tweise commented May 21, 2017

done

@@ -28,7 +28,7 @@ appropriate values (make sure this is all on one line):

$ mvn archetype:generate \
-DarchetypeGroupId=org.apache.apex \
-DarchetypeArtifactId=apex-app-archetype -DarchetypeVersion=3.4.0 \
-DarchetypeArtifactId=apex-app-archetype -DarchetypeVersion=RELEASE \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While maven supports RELEASE for the version resolution, it may be better not to use it in favor of predictable version specification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to use RELEASE in the example as that is what users almost always want when creating a new project. I added a line above to address this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@tweise tweise force-pushed the APEXCORE-725-config branch 2 times, most recently from e97a3de to 4cf6f45 Compare May 22, 2017 05:07
@tweise
Copy link
Contributor Author

tweise commented May 25, 2017

@amberarrow @vrozov can one of you merge this or add your LGTM so I can do it myself.

Copy link
Member

@vrozov vrozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit merged commit 47f1d91 into apache:master May 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants