APEXCORE-725 Example for configuring map properties. #529
Conversation
docs/application_packages.md
Outdated
syntax. For example, the connection properties of the JDBC store can be accessed | ||
like this: | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkdocs seems to render fenced code blocks better if the language is specified (xml in this instance) after the 3 backquotes. Without it we see some odd formatting with some words emboldened, others in a different color, etc. Maybe the 'xml' could also be added to the other blocks as well as appropriate.
Ready to merge once the comment is addressed. |
4d938a8
to
78e491f
Compare
done |
@@ -28,7 +28,7 @@ appropriate values (make sure this is all on one line): | |||
|
|||
$ mvn archetype:generate \ | |||
-DarchetypeGroupId=org.apache.apex \ | |||
-DarchetypeArtifactId=apex-app-archetype -DarchetypeVersion=3.4.0 \ | |||
-DarchetypeArtifactId=apex-app-archetype -DarchetypeVersion=RELEASE \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While maven supports RELEASE
for the version resolution, it may be better not to use it in favor of predictable version specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to use RELEASE in the example as that is what users almost always want when creating a new project. I added a line above to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
e97a3de
to
4cf6f45
Compare
4cf6f45
to
47f1d91
Compare
@amberarrow @vrozov can one of you merge this or add your LGTM so I can do it myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
R: @amberarrow