Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

APEXCORE-726 Setup up acls for impersonation #530

Merged
merged 1 commit into from May 31, 2017

Conversation

pramodin
Copy link
Contributor

@devtagare @amberarrow please see

@@ -0,0 +1,67 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new code needs to go into org.apache.apex packages

@@ -37,7 +37,6 @@
import org.slf4j.LoggerFactory;

import org.apache.apex.common.util.JarHelper;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid format changes

}
}

public static boolean areAclsRequired(Configuration conf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be named areACLsRequired ? We should be consistent in ACL vs Acl in identifier names

@pramodin pramodin force-pushed the APEXCORE-726 branch 2 times, most recently from 92c0879 to eeae8cc Compare May 29, 2017 18:48
…pplication when the application is launched with impersonation
@pramodin
Copy link
Contributor Author

squashed

Copy link
Contributor

@devtagare devtagare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit merged commit f2469f2 into apache:master May 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants