This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
APEXCORE-726 Setup up acls for impersonation #530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweise
suggested changes
May 25, 2017
@@ -0,0 +1,67 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new code needs to go into org.apache.apex packages
vrozov
reviewed
May 25, 2017
@@ -37,7 +37,6 @@ | |||
import org.slf4j.LoggerFactory; | |||
|
|||
import org.apache.apex.common.util.JarHelper; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid format changes
} | ||
} | ||
|
||
public static boolean areAclsRequired(Configuration conf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be named areACLsRequired
? We should be consistent in ACL vs Acl in identifier names
pramodin
force-pushed
the
APEXCORE-726
branch
2 times, most recently
from
May 29, 2017 18:48
92c0879
to
eeae8cc
Compare
…pplication when the application is launched with impersonation
squashed |
devtagare
approved these changes
May 31, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@devtagare @amberarrow please see