This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
APEXCORE-550 User friendly error message when Java version mismatch happens #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The most interesting use case is when mismatch happens on the cluster, not on the client. |
|
LGTM |
vrozov
reviewed
Sep 11, 2017
| @@ -1978,6 +1978,7 @@ public void execute(String[] args, ConsoleReader reader) throws Exception | |||
| if (ap != null) { | |||
| try { | |||
| if (!commandLineInfo.force) { | |||
| checkJdkVersionCompatible(ap); | |||
There was a problem hiding this comment.
How will the check work in case application is compiled using JDK 1.8 to be compatible with Java 7 or even any prior Java version (-target option)?
There was a problem hiding this comment.
@WenbinZhu Please reply or close the PR if you do not have time to look into it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.