APEXMALHAR-2019 S3-Input Implemented S3 Input Module #263
Conversation
| } | ||
|
|
||
| @VisibleForTesting | ||
| protected String extractBucket(String s3uri) |
chaithu14
force-pushed
the
APEXMALHAR-2019-S3-Input
branch
3 times, most recently
from
70f2a00
to
ecbdf2a
Compare
|
Addressed all the review comments. |
|
I see that this is using BlockReader, which is being deleted in PR #267. Please make sure that this is in line with other PR. So please hold off this till that time |
chaithu14
force-pushed
the
APEXMALHAR-2019-S3-Input
branch
from
ecbdf2a
to
e6d1858
Compare
|
Re-based with the master and updated the branch. |
|
@ashwinchandrap Please review and merge. |
chaithu14
force-pushed
the
APEXMALHAR-2019-S3-Input
branch
2 times, most recently
from
3a24cc2
to
88fa04c
Compare
|
Can we add test cases for this? |
chaithu14
force-pushed
the
APEXMALHAR-2019-S3-Input
branch
2 times, most recently
from
94e7959
to
13b041d
Compare
|
@gauravgopi123 Thanks for reviewing. I added unit test case for S3 Input Module. But, I marked the test case as excluded. Because to run this test case, the prerequisites are amazon credentials and hadoop. |
chaithu14
force-pushed
the
APEXMALHAR-2019-S3-Input
branch
from
13b041d
to
cc3d9f6
Compare
|
@chaithu14 Please make changes to the readEntity() javadoc and please rebase this branch. |
|
@chaithu14 Could you please mark the new classes with @ evolving? |
chaithu14
force-pushed
the
APEXMALHAR-2019-S3-Input
branch
from
cc3d9f6
to
aa2d476
Compare
chaithu14
force-pushed
the
APEXMALHAR-2019-S3-Input
branch
from
aa2d476
to
5de26e4
Compare
|
@yogidevendra : Incorporated review comments and marked the new classes with @ evolving. |
|
Looks fine to me. I will merge this tomorrow. |
No description provided.