This repository has been archived by the owner on May 12, 2021. It is now read-only.
APEXMALHAR-2134 Fix the NullPointerException, if the kafka partition has no leader broker #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siyuanh Please review and merge. |
| @@ -508,6 +508,9 @@ private void monitorMetadata() | |||
| continue; | |||
| } | |||
| Broker b = pm.leader(); | |||
| if (b == null) { | |||
| continue; | |||
There was a problem hiding this comment.
We should put a INFO log here.
There was a problem hiding this comment.
Added a log message and updated.
chaithu14
force-pushed
the
APEXMALHAR-2134-NP-LB
branch
from
8b662fb
to
0da1765
Compare
|
@chaithu14 can you rebase the PR so we get the unit test fix into the CI build. |
…has no leader broker
chaithu14
force-pushed
the
APEXMALHAR-2134-NP-LB
branch
from
0da1765
to
af425a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.