Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

APEXMALHAR-2479-regexparser-example #607

Merged

Conversation

venkateshkottapalli
Copy link
Contributor

@shubham-pathak22 Please review the regex parser example.

@venkateshkottapalli venkateshkottapalli force-pushed the APEXMALHAR-2479-regexparser-example branch 3 times, most recently from ddf1636 to 9492c13 Compare April 24, 2017 23:06
String line = "2015-10-01T03:14:49.000-07:00 lvn-d1-dev DevServer[9876]: INFO: [EVENT][SEQ=248717]" +
" 2015:10:01:03:14:49 101 sign-in_id=11111@psop.com ip_address=1.1.1.1 service_id=IP1234-NPB12345_00 " +
"result=RESULT_SUCCESconsole_id=0000000138e91b4e58236bf32besdafasdfasdfasdfsadf account_id=11111 platform=pik";
outputPort.emit(line.getBytes());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add few invalid records as well to show that those will be emitted from error port?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham-pathak22 added the error inputs as well.

@shubham-pathak22
Copy link
Contributor

@venkateshkottapalli I have added my comments. Also make sure travis build check passes.

@venkateshkottapalli venkateshkottapalli force-pushed the APEXMALHAR-2479-regexparser-example branch from 9492c13 to 2fe2903 Compare April 26, 2017 00:11
@venkateshkottapalli
Copy link
Contributor Author

@shubham-pathak22 Please check now.

@asfgit asfgit merged commit 2fe2903 into apache:master Apr 28, 2017
@@ -5,7 +5,7 @@ This app showcases **Json Parser**. Data generator sends Json data to the Json P

* **Csv Parser App**

This application showcases how to use CsvParser from [Apex Malhar](https://github.com/apache/apex-malhar) library. The CsvParser converts your delimited data to a key-value pair map or concrete java class also know as [POJO](https://en.wikipedia.org/wiki/Plain_Old_Java_Object). The parser emits key-value pair map on *parsedOutput* port. It emits POJO on *out* and error records on *err* port.
This application showcases how to use [CsvParser](https://datatorrent.com/docs/apidocs/com/datatorrent/contrib/parser/CsvParser.html) from [Apex Malhar](https://github.com/apache/apex-malhar) library. The CsvParser converts your delimited data to a key-value pair map or concrete java class also know as [POJO](https://en.wikipedia.org/wiki/Plain_Old_Java_Object). The parser emits key-value pair map on *parsedOutput* port. It emits POJO on *out* and error records on *err* port.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these links pointing to the datatorrent web site and not to the ASF hosted Javadoc?

@tweise
Copy link
Contributor

tweise commented Apr 29, 2017

@shubham-pathak22 since you are responsible for the merge, I would expect follow-up from you on this.

See also https://issues.apache.org/jira/browse/APEXMALHAR-2477, perhaps there can be a broader sweep.

@amberarrow FYI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants