APEXMALHAR-2547 nyc taxi example checkin #675
Conversation
davidyan74
force-pushed
the
nyc
branch
2 times, most recently
from
d041cc9
to
953135b
Compare
|
JIRA please. |
|
rat:check isn't happy about missing license headers. |
| @@ -207,7 +207,6 @@ public Thread newThread(Runnable r) | |||
| @Override | |||
| public void onMessage(String string) | |||
| { | |||
| LOG.debug("Got: " + string); | |||
There was a problem hiding this comment.
An accidental removal of the debug message or was it intentional?
There was a problem hiding this comment.
I thought we should remove it but I can put it back if you insist.
There was a problem hiding this comment.
No strong opinion either way just wanted to check it was not accidental removal. Wouldn't having the ability to see the received message be useful for debugging or are there other ways to get to it.
|
@tweise what should I do re: the license headers in csv? csv does not support comment. |
davidyan74
changed the title
| import com.datatorrent.lib.io.PubSubWebSocketAppDataQuery; | ||
| import com.datatorrent.lib.io.PubSubWebSocketAppDataResult; | ||
|
|
||
| /** |
|
@davidyan74 you may have to add the *.csv exclusion to the top level pom.xml for both, the license and rat plugins. So far it only occurred in test resources. |
|
Added csv exclusion. Thanks. |
|
see #677 for test failure |
|
@davidyan74 rebase |
|
@tweise Looks like the flume sink test is still stalling. |
|
@tweise Hmmm. Looks like the test is flaky. |
@tweise please take a look. thanks.