Add respbody error assertion and defer resp.Body.Close ()

apache · Mar 1, 2021 · d75b79a · d75b79a
1 parent be91a89
commit d75b79a
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/api/test/e2enew/ssl/ssl_test.go b/api/test/e2enew/ssl/ssl_test.go
@@ -57,6 +57,7 @@ var _ = ginkgo.Describe("SSL Basic", func() {
 			"cert": string(testCert),
 			"key":  string(apisixKey),
 		})
+		assert.Nil(t, err)
 		// Before configuring SSL, make a HTTPS request
 		http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
 		http.DefaultTransport.(*http.Transport).DialContext = func(ctx context.Context, network, addr string) (net.Conn, error) {
@@ -68,6 +69,7 @@ var _ = ginkgo.Describe("SSL Basic", func() {
 		}
 		_, err = http.Get("https://www.test2.com:9443")
 		assert.NotNil(t, err)
+		defer resp.Body.Close()
 		assert.EqualError(t, err, "Get https://www.test2.com:9443: remote error: tls: internal error")
 		//create ssl fail - key and cert not match
 		base.RunTestCase(base.HttpTestCase{
@@ -166,6 +168,7 @@ var _ = ginkgo.Describe("SSL Basic", func() {
 		time.Sleep(time.Duration(500) * time.Millisecond)
 		_, err := http.Get("https://www.test2.com:9443")
 		assert.NotNil(t, err)
+		defer resp.Body.Close()
 		assert.EqualError(t, err, "Get https://www.test2.com:9443: remote error: tls: internal error")
 	})
 	ginkgo.It("enable SSL", func() {