Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: verifying the version number #1695

Closed
iamayushdas opened this issue Mar 31, 2021 · 0 comments · Fixed by #1696
Closed

[Bug]: verifying the version number #1695

iamayushdas opened this issue Mar 31, 2021 · 0 comments · Fixed by #1696
Labels
backend bug Something isn't working

Comments

@iamayushdas
Copy link
Contributor

Issue description

unable to verify version number

Expected behavior

2.4 version should get verified

This is because when verifying the version number, the . In 2.4 is used as a regular expression to match all strings.
You could submit another commit to avoid this problem.
To fix this problem, we could change this line of code
https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L177
to :

if [[ `grep -c -w "${VERSION}" ${STDOUT}` -ne '1' ]]; then
@iamayushdas iamayushdas added the bug Something isn't working label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants