Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: delete wait in test #1370

Merged
merged 5 commits into from
Jan 26, 2021
Merged

test: delete wait in test #1370

merged 5 commits into from
Jan 26, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Jan 25, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

New feature or improvement

  • Describe the details and related test reports.
    Delete all wait in test

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #1370 (8d8654d) into master (7a157af) will decrease coverage by 14.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1370       +/-   ##
===========================================
- Coverage   62.62%   48.55%   -14.07%     
===========================================
  Files          41       42        +1     
  Lines        2360     2395       +35     
===========================================
- Hits         1478     1163      -315     
- Misses        706     1032      +326     
- Partials      176      200       +24     
Impacted Files Coverage Δ
api/internal/core/store/query.go 0.00% <0.00%> (-88.10%) ⬇️
api/internal/utils/consts/api_error.go 17.39% <0.00%> (-78.27%) ⬇️
api/internal/core/store/selector.go 0.00% <0.00%> (-75.93%) ⬇️
api/internal/handler/plugin/plugin.go 16.66% <0.00%> (-70.00%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/filter/authentication.go 44.11% <0.00%> (-32.36%) ⬇️
api/internal/core/store/store.go 56.32% <0.00%> (-29.75%) ⬇️
api/internal/handler/global_rule/global_rule.go 62.71% <0.00%> (-20.34%) ⬇️
api/internal/handler/consumer/consumer.go 74.46% <0.00%> (-17.03%) ⬇️
api/internal/handler/route/route.go 50.43% <0.00%> (-16.96%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a157af...8d8654d. Read the comment docs.

@juzhiyuan juzhiyuan marked this pull request as draft January 25, 2021 07:04
@guoqqqi guoqqqi marked this pull request as ready for review January 26, 2021 03:51
@moonming
Copy link
Member

Nice

@moonming moonming merged commit e03dc9c into apache:master Jan 26, 2021
@juzhiyuan juzhiyuan deleted the delete-wait-test branch January 26, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants