Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add edit the plugin #1372

Merged
merged 25 commits into from
Jan 28, 2021
Merged

test: add edit the plugin #1372

merged 25 commits into from
Jan 28, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Jan 25, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues
    resolve test: add FE e2e test for global plugin #1156

  • Describe the details and related test reports.
    add edit the plugin test

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #1372 (d7916b2) into master (1bdcaa8) will decrease coverage by 18.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1372       +/-   ##
===========================================
- Coverage   62.29%   43.86%   -18.43%     
===========================================
  Files          42       35        -7     
  Lines        2395     2512      +117     
===========================================
- Hits         1492     1102      -390     
- Misses        722     1253      +531     
+ Partials      181      157       -24     
Impacted Files Coverage Δ
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-95.66%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-74.49%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-62.50%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/handler/server_info/server_info.go 57.14% <0.00%> (-33.34%) ⬇️
api/internal/utils/closer.go 0.00% <0.00%> (-33.34%) ⬇️
api/internal/handler/consumer/consumer.go 63.82% <0.00%> (-27.66%) ⬇️
api/internal/utils/pid.go 0.00% <0.00%> (-26.67%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdcaa8...d7916b2. Read the comment docs.

@juzhiyuan juzhiyuan mentioned this pull request Jan 26, 2021
4 tasks
@liuxiran
Copy link
Contributor

I got how to muilt delete route items in the list from this pr, thanks a lot^_^

@juzhiyuan juzhiyuan mentioned this pull request Jan 28, 2021
4 tasks
@liuxiran
Copy link
Contributor

there is something wrong with CI, maybe you need to force push to retrigger it at your convenience

@guoqqqi guoqqqi closed this Jan 28, 2021
@guoqqqi guoqqqi reopened this Jan 28, 2021
@guoqqqi
Copy link
Member Author

guoqqqi commented Jan 28, 2021

image
I had to use wait() to block consecutive clicks in the global function because of the force property, I tried many ways to replace wait(), but they all failed, if there is a good way, please feel free to suggest me,very thanks

@liuxiran
Copy link
Contributor

image
I had to use wait() to block consecutive clicks in the global function because of the force property, I tried many ways to replace wait(), but they all failed, if there is a good way, please feel free to suggest me,very thanks

how about meger this pr first to let the blocked prs merge normally, and then we come back to optimize this problem.

cc @juzhiyuan @LiteSun

@juzhiyuan
Copy link
Member

Agree, @guoqqqi please create an issue to track this notice, too.

@liuxiran liuxiran merged commit fb048ee into apache:master Jan 28, 2021
@guoqqqi guoqqqi deleted the test-global-plugin branch January 28, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add FE e2e test for global plugin
4 participants