Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tips on login page #1491

Merged
merged 2 commits into from
Feb 22, 2021
Merged

add tips on login page #1491

merged 2 commits into from
Feb 22, 2021

Conversation

Baoyuantop
Copy link
Contributor

@Baoyuantop Baoyuantop commented Feb 21, 2021

Please answer these questions before submitting a pull request

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Related issues
resolve #1488

@codecov-io
Copy link

codecov-io commented Feb 21, 2021

Codecov Report

Merging #1491 (037d9fb) into master (65f792a) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1491      +/-   ##
==========================================
+ Coverage   68.43%   68.69%   +0.26%     
==========================================
  Files          48       48              
  Lines        3038     3038              
==========================================
+ Hits         2079     2087       +8     
+ Misses        720      712       -8     
  Partials      239      239              
Impacted Files Coverage Δ
api/internal/core/store/store.go 87.95% <0.00%> (+1.20%) ⬆️
api/internal/core/storage/etcd.go 47.27% <0.00%> (+5.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f792a...037d9fb. Read the comment docs.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Tip PR

web/src/pages/User/locales/en-US.ts Outdated Show resolved Hide resolved
web/src/pages/User/locales/zh-CN.ts Outdated Show resolved Hide resolved
@juzhiyuan
Copy link
Member

@Baoyuantop Hi, could you please take some screenshots on Login page?

@Baoyuantop
Copy link
Contributor Author

截屏2021-02-21 下午4 48 08

截屏2021-02-21 下午4 48 35

@juzhiyuan
Copy link
Member

juzhiyuan commented Feb 21, 2021

image

@Baoyuantop It could be more closer in a future PR :)

@Baoyuantop
Copy link
Contributor Author

I will continue to improve in future PR

@LiteSun LiteSun merged commit e56163a into apache:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tips on the Login page
4 participants