Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incomplete i18n coverage #1538

Merged
merged 12 commits into from
Mar 16, 2021
Merged

fix: Incomplete i18n coverage #1538

merged 12 commits into from
Mar 16, 2021

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request


Bugfix

  • Description
    fixed Incomplete i18n coverage
  • How to fix?
    Upgraded @ant-design/pro-table component to the latest version

New feature or improvement

  • Describe the details and related test reports.

Please add the corresponding test cases if necessary.


Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@codecov-io
Copy link

codecov-io commented Mar 2, 2021

Codecov Report

Merging #1538 (bd9551b) into master (40d1dab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1538   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          46       46           
  Lines        3019     3019           
=======================================
  Hits         2122     2122           
  Misses        652      652           
  Partials      245      245           
Flag Coverage Δ
backend-e2e-test 60.88% <ø> (+0.03%) ⬆️
backend-e2e-test-ginkgo 46.27% <ø> (-0.04%) ⬇️
backend-unit-test 51.50% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/store.go 87.34% <0.00%> (-0.61%) ⬇️
api/cmd/managerapi.go 59.45% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d1dab...bd9551b. Read the comment docs.

@juzhiyuan
Copy link
Member

cc @guoqqqi to review.

@juzhiyuan juzhiyuan requested a review from LiteSun March 2, 2021 06:25
@juzhiyuan
Copy link
Member

CI failed

@juzhiyuan juzhiyuan changed the title fix Incomplete i18n coverage fix: Incomplete i18n coverage Mar 4, 2021
@guoqqqi guoqqqi mentioned this pull request Mar 4, 2021
4 tasks
@guoqqqi guoqqqi mentioned this pull request Mar 5, 2021
4 tasks
@LiteSun
Copy link
Member

LiteSun commented Mar 10, 2021

@nic-chen Backend CLI Test failed,please take a look when you have time

@nic-chen
Copy link
Member

Strange, there is no problem with other PRs.
Could you sync the master code first please? @Baoyuantop

@nic-chen
Copy link
Member

After I synchronized the master code, it did not appear again. I feel that it was affected by the github CI mechanism. The backend cli test has not been updated for a while.

@liuxiran
Copy link
Contributor

https://github.com/apache/apisix-dashboard/pull/1538/checks?check_run_id=2084118899

try to fix in #1590

@juzhiyuan juzhiyuan mentioned this pull request Mar 14, 2021
1 task
@LiteSun LiteSun requested a review from nic-chen March 16, 2021 01:19
@liuxiran liuxiran merged commit e95a189 into apache:master Mar 16, 2021
@liuxiran
Copy link
Contributor

merged, thanks a lot

@juzhiyuan juzhiyuan mentioned this pull request Mar 16, 2021
@LiteSun LiteSun mentioned this pull request Mar 16, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants