Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add the create and delete plugin in drawer #1597

Merged
merged 20 commits into from
Mar 22, 2021
Merged

test: add the create and delete plugin in drawer #1597

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4a93880
test: add the create and delter plugin in drawer
stu01509 Mar 15, 2021
fc10167
test: add the create and delter plugin in drawer
stu01509 Mar 16, 2021
0fffb5e
Merge remote-tracking branch 'upstream/master' into fix-#1411-add-del…
stu01509 Mar 19, 2021
bf6915f
test: add the create and delter plugin in drawer
stu01509 Mar 19, 2021
9577f51
test: adjust the create and delter plugin in drawer
stu01509 Mar 20, 2021
0054591
test: adjust the create and delter plugin in drawer
stu01509 Mar 20, 2021
053740e
test: adjust the create and delter plugin in drawer
stu01509 Mar 20, 2021
6fe03a2
Merge remote-tracking branch 'upstream/master' into fix-#1411-add-del…
stu01509 Mar 21, 2021
2e49eca
test: adjust the create and delter plugin in drawer
stu01509 Mar 21, 2021
9ec5acb
test: adjust the create and delter plugin in drawer
stu01509 Mar 21, 2021
bb28992
test: adjust the create and delter plugin in drawer
stu01509 Mar 21, 2021
1367477
test: adjust the create and delter plugin in drawer
stu01509 Mar 21, 2021
99a4275
test: adjust the create and delter plugin in drawer
stu01509 Mar 21, 2021
2a561ac
test: adjust the create and delter plugin in drawer
stu01509 Mar 21, 2021
e7d7609
Merge remote-tracking branch 'upstream/master' into fix-#1411-add-del…
stu01509 Mar 21, 2021
b7857f0
test: adjust test data.json and selector.json files
stu01509 Mar 22, 2021
af1f43f
Merge branch 'master' into fix-#1411-add-delete-plugin-in-darwer
LiteSun Mar 22, 2021
8331f4a
Merge branch 'master' into fix-#1411-add-delete-plugin-in-darwer
stu01509 Mar 22, 2021
34b2d85
test: adjust test data.json and selector.json files
stu01509 Mar 22, 2021
9cdd1f2
Merge branch 'fix-#1411-add-delete-plugin-in-darwer' of github.com:st…
stu01509 Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ context('Create and Delete Plugin List', () => {
.then(() => {
cy.get('.ant-drawer-footer').contains('button', 'Delete').click();
cy.contains('button', 'Confirm').click({ force: true });
cy.get(this.domSelector.empty).should('be.visible');
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion ensures that the plugin can be removed in its entirety properly, and I think it's best that we don't remove it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update here?

});
});