Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the button margin space #1604

Merged
merged 4 commits into from
Mar 22, 2021
Merged

fix: fix the button margin space #1604

merged 4 commits into from
Mar 22, 2021

Conversation

stu01509
Copy link
Contributor

@stu01509 stu01509 commented Mar 17, 2021

Please answer these questions before submitting a pull request


Bugfix

  • Description
    Use and Space to add each button's margin, and remove inline margin style.

image

@juzhiyuan juzhiyuan requested a review from LiteSun March 17, 2021 02:53
@juzhiyuan
Copy link
Member

also cc @guoqqqi to take a look

@guoqqqi
Copy link
Member

guoqqqi commented Mar 18, 2021

wait for #1608

@codecov-io
Copy link

codecov-io commented Mar 19, 2021

Codecov Report

Merging #1604 (07fb5fe) into master (548bbe3) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
+ Coverage   71.05%   71.24%   +0.19%     
==========================================
  Files          47       47              
  Lines        3116     3116              
==========================================
+ Hits         2214     2220       +6     
+ Misses        658      653       -5     
+ Partials      244      243       -1     
Flag Coverage Δ
backend-e2e-test 61.97% <ø> (+0.19%) ⬆️
backend-e2e-test-ginkgo 47.91% <ø> (ø)
backend-unit-test 51.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/store.go 89.15% <0.00%> (+1.20%) ⬆️
api/internal/core/storage/etcd.go 47.27% <0.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548bbe3...07fb5fe. Read the comment docs.

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stu01509
Copy link
Contributor Author

Hi @liuxiran

Update the commit.

@liuxiran
Copy link
Contributor

Hi @liuxiran

Update the commit.

LGTM, be ci errors have been solved by #1638 , please try to update master to soluve it, thanks @stu01509

@juzhiyuan juzhiyuan requested a review from nic-chen March 22, 2021 08:43
@juzhiyuan juzhiyuan merged commit 968c15f into apache:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There have 2 buttons fit very close together
7 participants