feat: improve the config plugin button enable disable status #1610

stu01509 · 2021-03-17T17:27:27Z

Please answer these questions before submitting a pull request

Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Fix Config Plugin button enable status #1586

New feature or improvement

Describe the details and related test reports.

Improve the config plugin button status, also I didn't found the 启用 and 禁用 in our current locales files, please help me to translate it, thanks.

juzhiyuan · 2021-03-18T02:10:39Z

Hi @stu01509, you could cc @guoqqqi to guide you how to resolve CI testcases.

guoqqqi · 2021-03-20T04:57:26Z

The test failed because when the button was clicked, the button became Disable and the Disable button was not found.
You can fix line 59 by changing
cy.contains('Enable') to cy.get('button') to fix it.

…button-enable-status

codecov-io · 2021-03-20T05:34:56Z

Codecov Report

Merging #1610 (e9a8d9f) into master (c68e2d2) will decrease coverage by 4.98%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1610      +/-   ##
==========================================
- Coverage   72.01%   67.02%   -4.99%     
==========================================
  Files         160      160              
  Lines        5820     5822       +2     
  Branches      651      653       +2     
==========================================
- Hits         4191     3902     -289     
- Misses       1385     1607     +222     
- Partials      244      313      +69

Flag	Coverage Δ
backend-e2e-test	`62.30% <ø> (ø)`
backend-e2e-test-ginkgo	`49.16% <ø> (+0.09%)`	⬆️
backend-unit-test	`?`
frontend-e2e-test	`72.49% <100.00%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
web/src/components/Plugin/PluginPage.tsx	`98.71% <100.00%> (+0.03%)`	⬆️
api/internal/utils/runtime/runtime.go	`0.00% <0.00%> (-64.29%)`	⬇️
api/internal/core/store/validate_mock.go	`0.00% <0.00%> (-50.00%)`	⬇️
api/internal/filter/authentication.go	`47.22% <0.00%> (-30.56%)`	⬇️
api/internal/handler/service/service.go	`62.60% <0.00%> (-29.57%)`	⬇️
api/internal/core/store/store.go	`58.43% <0.00%> (-29.52%)`	⬇️
api/internal/filter/ip_filter.go	`48.71% <0.00%> (-23.08%)`	⬇️
api/internal/handler/global_rule/global_rule.go	`64.51% <0.00%> (-19.36%)`	⬇️
...pi/internal/handler/plugin_config/plugin_config.go	`59.57% <0.00%> (-18.09%)`	⬇️
api/internal/utils/json_patch.go	`44.82% <0.00%> (-13.80%)`	⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68e2d2...e9a8d9f. Read the comment docs.

web/src/components/Plugin/PluginPage.tsx

stu01509 · 2021-03-22T00:39:04Z

Hi @juzhiyuan and @guoqqqi

Update the commit :)

nic-chen · 2021-03-23T07:33:09Z

@stu01509 please sync codes from branch master

…button-enable-status

stu01509 · 2021-03-23T07:34:38Z

@stu01509 please sync codes from branch master

Done.

…button-enable-status

web/cypress/integration/service/edit-service-with-upstream.spec.js

juzhiyuan · 2021-04-01T01:13:22Z

@stu01509 Hi, here are some conflicts, please take a look.

stu01509 · 2021-04-02T09:18:41Z

Hi @juzhiyuan

Update the commit :)

juzhiyuan · 2021-04-02T10:10:14Z

@stu01509 Hi, please run yarn build, and you will get error messages.

stu01509 · 2021-04-02T13:28:44Z

Hi @juzhiyuan and @guoqqqi

Update the commit, and passed the CI,
please review it again :)

web/src/components/Plugin/PluginPage.tsx

guoqqqi · 2021-04-05T12:32:40Z

LGTM, Thanks!

netlify · 2021-04-12T15:05:17Z

Deploy preview for apisix-dashboard ready!

Built with commit 5bc61a4

https://deploy-preview-1610--apisix-dashboard.netlify.app

juzhiyuan · 2021-04-13T03:27:54Z

ping @liuxiran @bzp2010

juzhiyuan · 2021-04-14T10:52:32Z

@stu01509 Hi, to prevent from CI failed, please merge the latest codes into your branch :) Thanks

juzhiyuan · 2021-04-16T21:50:13Z

I noticed this CI failed, that's because this PR changes something related to testcases, it's not hard to fix it.

…button-enable-status

…u01509/apisix-dashboard into fix-#1586-plugin-button-enable-status

codecov-commenter · 2021-04-18T04:22:07Z

Codecov Report

❗ No coverage uploaded for pull request base (master@f1b8f0c). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1610   +/-   ##
=========================================
  Coverage          ?   72.14%           
=========================================
  Files             ?      125           
  Lines             ?     2908           
  Branches          ?      701           
=========================================
  Hits              ?     2098           
  Misses            ?      810           
  Partials          ?        0

Flag	Coverage Δ
frontend-e2e-test	`72.14% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
web/src/components/Plugin/PluginPage.tsx	`98.70% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b8f0c...5bc61a4. Read the comment docs.

stu01509 · 2021-04-18T04:46:07Z

Hi @juzhiyuan

Update the commit, sorry for the delayed reply.

juzhiyuan · 2021-04-18T09:34:32Z

web/cypress/integration/route/create-route-with-limit-count-plugin-form.spec.js

@@ -57,7 +57,7 @@ context('Create and delete route with limit-count form', () => {

    // config limit-count form with local policy
    cy.contains(this.domSelector.pluginCard, 'limit-count').within(() => {
-      cy.contains('Enable').click({
+      cy.get('button').click({


If we have multiple buttons, which one it will take?

Still need some tests :)

juzhiyuan · 2021-04-18T09:36:21Z

@guoqqqi Please recheck this PR, and merge the latest master codes to this one, and see if it's working properly, thanks!

feat: imporve the confing plugin button enable disable status

6e74244

juzhiyuan requested a review from LiteSun March 18, 2021 02:09

stu01509 added 2 commits March 20, 2021 13:32

test: fix plugin enable status

317b69f

Merge remote-tracking branch 'upstream/master' into fix-#1586-plugin-…

e2060e3

…button-enable-status

stu01509 commented Mar 21, 2021

View reviewed changes

web/src/components/Plugin/PluginPage.tsx Outdated Show resolved Hide resolved

feat: add the enable disable translation

b21caf8

Merge remote-tracking branch 'upstream/master' into fix-#1586-plugin-…

ec6a750

…button-enable-status

stu01509 added 2 commits March 25, 2021 12:55

Merge remote-tracking branch 'upstream/master' into fix-#1586-plugin-…

0736cf0

…button-enable-status

test: improve cypress test case

714c999

guoqqqi reviewed Mar 31, 2021

View reviewed changes

web/cypress/integration/service/edit-service-with-upstream.spec.js Outdated Show resolved Hide resolved

Merge branch 'master' into fix-#1586-plugin-button-enable-status

dc46978

stu01509 added 2 commits April 2, 2021 18:54

test: fix ci error

eea4871

feat: remove unnecessary boolean condition

1320abd

juzhiyuan reviewed Apr 2, 2021

View reviewed changes

web/src/components/Plugin/PluginPage.tsx Outdated Show resolved Hide resolved

guoqqqi reviewed Apr 2, 2021

View reviewed changes

web/src/components/Plugin/PluginPage.tsx Outdated Show resolved Hide resolved

feat: adjust enable disable status style

11a14fb

juzhiyuan requested review from bzp2010, Jaycean and liuxiran April 3, 2021 07:53

guoqqqi approved these changes Apr 5, 2021

View reviewed changes

LiteSun approved these changes Apr 6, 2021

View reviewed changes

juzhiyuan previously approved these changes Apr 6, 2021

View reviewed changes

LiteSun approved these changes Apr 12, 2021

View reviewed changes

juzhiyuan mentioned this pull request Apr 12, 2021

feat: added types for Plugins #1736

Merged

11 tasks

Merge branch 'master' into fix-#1586-plugin-button-enable-status

e9a8d9f

Merge branch 'master' into fix-#1586-plugin-button-enable-status

8b69a6b

nic-chen approved these changes Apr 15, 2021

View reviewed changes

Merge branch 'master' into fix-#1586-plugin-button-enable-status

9564a41

stu01509 added 4 commits April 18, 2021 11:13

Merge remote-tracking branch 'upstream/master' into fix-#1586-plugin-…

8641706

…button-enable-status

test: fix cypress test case

7fe3e3d

Merge branch 'fix-#1586-plugin-button-enable-status' of github.com:st…

473cdcf

…u01509/apisix-dashboard into fix-#1586-plugin-button-enable-status

test: fix cypress test case error

5bc61a4

stu01509 requested a review from juzhiyuan April 18, 2021 04:43

juzhiyuan reviewed Apr 18, 2021

View reviewed changes

juzhiyuan approved these changes Apr 18, 2021

View reviewed changes

juzhiyuan merged commit c9d2bd3 into apache:master Apr 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve the config plugin button enable disable status #1610

feat: improve the config plugin button enable disable status #1610

stu01509 commented Mar 17, 2021

juzhiyuan commented Mar 18, 2021

guoqqqi commented Mar 20, 2021 •

edited

Loading

codecov-io commented Mar 20, 2021 •

edited

Loading

stu01509 commented Mar 22, 2021

nic-chen commented Mar 23, 2021

stu01509 commented Mar 23, 2021

juzhiyuan commented Apr 1, 2021

stu01509 commented Apr 2, 2021

juzhiyuan commented Apr 2, 2021

stu01509 commented Apr 2, 2021

guoqqqi commented Apr 5, 2021

netlify bot commented Apr 12, 2021 •

edited

Loading

juzhiyuan commented Apr 13, 2021

juzhiyuan commented Apr 14, 2021

juzhiyuan commented Apr 16, 2021

codecov-commenter commented Apr 18, 2021

stu01509 commented Apr 18, 2021

juzhiyuan Apr 18, 2021

juzhiyuan commented Apr 18, 2021

feat: improve the config plugin button enable disable status #1610

feat: improve the config plugin button enable disable status #1610

Conversation

stu01509 commented Mar 17, 2021

New feature or improvement

juzhiyuan commented Mar 18, 2021

guoqqqi commented Mar 20, 2021 • edited Loading

codecov-io commented Mar 20, 2021 • edited Loading

Codecov Report

stu01509 commented Mar 22, 2021

nic-chen commented Mar 23, 2021

stu01509 commented Mar 23, 2021

juzhiyuan commented Apr 1, 2021

stu01509 commented Apr 2, 2021

juzhiyuan commented Apr 2, 2021

stu01509 commented Apr 2, 2021

guoqqqi commented Apr 5, 2021

netlify bot commented Apr 12, 2021 • edited Loading

juzhiyuan commented Apr 13, 2021

juzhiyuan commented Apr 14, 2021

juzhiyuan commented Apr 16, 2021

codecov-commenter commented Apr 18, 2021

Codecov Report

stu01509 commented Apr 18, 2021

juzhiyuan Apr 18, 2021

Choose a reason for hiding this comment

juzhiyuan commented Apr 18, 2021

guoqqqi commented Mar 20, 2021 •

edited

Loading

codecov-io commented Mar 20, 2021 •

edited

Loading

netlify bot commented Apr 12, 2021 •

edited

Loading