fix: user login request should remove its own prefix option #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1701 +/- ##
===========================================
- Coverage 72.61% 52.29% -20.33%
===========================================
Files 133 38 -95
Lines 5741 2660 -3081
Branches 668 0 -668
===========================================
- Hits 4169 1391 -2778
+ Misses 1329 1081 -248
+ Partials 243 188 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
juzhiyuan
reviewed
Apr 1, 2021
zzzdong
force-pushed
the
fix-login-api-prefix
branch
from
f078bf1
to
c70d8e6
Compare
juzhiyuan
approved these changes
Apr 6, 2021
membphis
approved these changes
Apr 9, 2021
nic-chen
reviewed
Apr 12, 2021
| @@ -102,10 +102,9 @@ const LoginMethodPassword: UserModule.LoginMethod = { | |||
| submit: async ({ username, password }) => { | |||
| if (username !== '' && password !== '') { | |||
| try { | |||
| const result = await request('/apisix/admin/user/login', { | |||
| const result = await request('/user/login', { | |||
There was a problem hiding this comment.
Do we need to update related test cases?
bzp2010
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
user login request should remove its own prefix option
Related issues
Checklist: