-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: user login request should remove its own prefix option #1701
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1701 +/- ##
===========================================
- Coverage 72.61% 52.29% -20.33%
===========================================
Files 133 38 -95
Lines 5741 2660 -3081
Branches 668 0 -668
===========================================
- Hits 4169 1391 -2778
+ Misses 1329 1081 -248
+ Partials 243 188 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f078bf1
to
c70d8e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -102,10 +102,9 @@ const LoginMethodPassword: UserModule.LoginMethod = { | |||
submit: async ({ username, password }) => { | |||
if (username !== '' && password !== '') { | |||
try { | |||
const result = await request('/apisix/admin/user/login', { | |||
const result = await request('/user/login', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update related test cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request will handle this :)
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
user login request should remove its own prefix option
Related issues
Checklist: