Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve Route module #1715

Merged
merged 17 commits into from Apr 9, 2021
Merged

chore: improve Route module #1715

merged 17 commits into from Apr 9, 2021

Conversation

juzhiyuan
Copy link
Member

@juzhiyuan juzhiyuan commented Apr 7, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • User Friendly

What changes will this PR take into?

  • Update Route List: added route Description
  • Update Route List: move advanced features into Dropdown
  • Route Creator: added fields description & samples (in progress)
  • Route Creator: refactor Fields into smaller component
  • UI: use Row & Col to unify UIs

Related issues

None

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases? (TODO)
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Screenshot
image

@juzhiyuan juzhiyuan marked this pull request as draft April 8, 2021 02:40
@juzhiyuan juzhiyuan marked this pull request as ready for review April 8, 2021 07:42
@juzhiyuan
Copy link
Member Author

As for Testcases, failed due to the Text change. Please review Text i18n & description first.

@juzhiyuan juzhiyuan requested a review from LiteSun April 8, 2021 09:22
@juzhiyuan
Copy link
Member Author

This PR mainly contains changes about i18n key & added some fields description, no logic changes.

@juzhiyuan
Copy link
Member Author

for other fields, I will send a new PR.

Copy link
Member

@LiteSun LiteSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for CI failure. Please fix it.

@codecov-io
Copy link

codecov-io commented Apr 8, 2021

Codecov Report

Merging #1715 (b4c5cf8) into master (82ab89e) will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
- Coverage   72.04%   71.67%   -0.37%     
==========================================
  Files         132       47      -85     
  Lines        5687     3128    -2559     
  Branches      660        0     -660     
==========================================
- Hits         4097     2242    -1855     
+ Misses       1346      643     -703     
+ Partials      244      243       -1     
Flag Coverage Δ
backend-e2e-test 62.53% <ø> (+0.28%) ⬆️
backend-e2e-test-ginkgo 49.39% <ø> (+0.35%) ⬆️
backend-unit-test 52.29% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/store.go 86.74% <0.00%> (-1.21%) ⬇️
.../components/PluginOrchestration/DrawPluginStyle.ts
web/src/pages/PluginTemplate/Create.tsx
web/src/pages/Upstream/Create.tsx
web/src/pages/Upstream/transform.ts
web/src/components/Plugin/PluginDetail.tsx
web/src/pages/Dashboard/Dashboard.tsx
web/src/pages/Dashboard/service.ts
.../src/pages/User/components/LoginMethodPassword.tsx
web/src/components/IconFont/IconFont.tsx
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ab89e...b4c5cf8. Read the comment docs.

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the code, it would be better to fix ci errors before approved, thanks

@juzhiyuan
Copy link
Member Author

Sure, because we have many text changes, need some time to fix them haha

@membphis
Copy link
Member

membphis commented Apr 9, 2021

Frontend e2e test / Frontend e2e test (pull_request)

ci failed

@juzhiyuan
Copy link
Member Author

yes, I'm fixing those CIs.

@juzhiyuan
Copy link
Member Author

debugging, 3 tests left.

@juzhiyuan juzhiyuan merged commit 30d98af into master Apr 9, 2021
@juzhiyuan juzhiyuan deleted the chore-route branch April 9, 2021 12:18
juzhiyuan added a commit to juzhiyuan/apisix-dashboard that referenced this pull request Apr 9, 2021
chore: improve Route module (apache#1715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants